Skip to content

chore(librarian): update gapic-generator to 1.30.5#15486

Merged
parthea merged 1 commit intomainfrom
parthea-patch-9
Jan 26, 2026
Merged

chore(librarian): update gapic-generator to 1.30.5#15486
parthea merged 1 commit intomainfrom
parthea-patch-9

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 26, 2026 •
edited
Loading

This PR is needed to address the following failure in PR #15458 when attempting to enable the mypy presubmit.

.nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/compute_v1beta/services/wire_groups/transports/base.py:88: error: Name "Any" is not defined  [name-defined]
.nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/compute_v1beta/services/wire_groups/transports/base.py:88: note: Did you forget to import it from "typing"? (Suggestion: "from typing import Any")
.nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/compute_v1beta/services/vpn_tunnels/transports/base.py:88: error: Name "Any" is not defined  [name-defined]

See googleapis/gapic-generator-python#2536 for more details

@parthea parthea requested review from a team as code owners January 26, 2026 19:44
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 26, 2026

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on resolving a critical mypy type-checking failure by upgrading the gapic-generator dependency. The update ensures that generated code correctly handles type hints, specifically the Any type, thereby preventing build failures and maintaining the integrity of static analysis checks.

Highlights

  • Dependency Update: The gapic-generator dependency has been updated from version 1.30.4 to 1.30.5 in .generator/requirements.in.
  • Mypy Fix: This update specifically addresses a mypy type-checking error where the Any type was reported as undefined in generated code, resolving a failure in a related pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gapic-generator dependency to version 1.30.5. The purpose of this update is to resolve a mypy failure that occurs with Python 3.14, as detailed in the pull request description. The change is a simple version bump in the requirements file and is well-documented with a comment linking to the relevant fix. The update appears correct and necessary.

@parthea parthea merged commit 287a913 into main Jan 26, 2026
26 checks passed
@parthea parthea deleted the parthea-patch-9 branch January 26, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @daniel-sanche